Skip to content

Conversation

@jgrey4296
Copy link
Contributor

As mentioned in issue 384, this

  • removes the eask repl command from eask-special-p so it loads the Eask file and correctly sets the load-path.
  • adds eask test buttercup to eask-execution-p so the eask--error and eask--warn advice are not applied, which can crash buttercup tests checking for error signals.

@jcs090218
Copy link
Member

The "test/buttercup" looks good.

The command eask repl is designed to be used with/without the Eask file. Is your Eask file not being loaded correctly? 🤔

Under project:

> eask repl
A message from the project local Eask file!!
*** Welcome to IELM ***  Type (describe-mode) or press C-h m for help.
ELISP> (kill-emacs)

With global Eask file:

> eask repl
A message from the home dir Eask file!!
*** Welcome to IELM ***  Type (describe-mode) or press C-h m for help.
ELISP> (kill-emacs)

Without global Eask file:

> eask repl
*** Welcome to IELM ***  Type (describe-mode) or press C-h m for help.
ELISP> (kill-emacs)

@jcs090218 jcs090218 merged commit 8b38fbc into emacs-eask:master Jan 23, 2026
131 checks passed
@jcs090218
Copy link
Member

I have applied the proper fix in #386.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants